Skip to content

Conversation

@m1so
Copy link
Member

@m1so m1so commented Nov 1, 2025

Summary by CodeRabbit

  • Chores
    • Released Deepnote toolkit as a stable version (1.0.0).

@m1so m1so marked this pull request as ready for review November 1, 2025 16:32
@m1so m1so requested a review from a team as a code owner November 1, 2025 16:32
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2025

📝 Walkthrough

Walkthrough

The Deepnote toolkit version constant is bumped from a release candidate (1.0.0rc2) to the official release version (1.0.0). No other code or logic changes are present.

Possibly related PRs

Suggested reviewers

  • Artmann
  • saltenasl
  • jamesbhobbs

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: Upgrade Toolkit to v1" directly and accurately describes the sole change: updating DEEPNOTE_TOOLKIT_VERSION from '1.0.0rc2' to '1.0.0'. The title is concise, uses appropriate terminology, and clearly conveys the primary objective to anyone reviewing the commit history. The "chore:" prefix is correctly applied for a version bump.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2cf42fd and a5bde90.

📒 Files selected for processing (1)
  • src/kernels/deepnote/types.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/!(*.node|*.web).ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Place shared cross-platform logic in common .ts files (not suffixed with .node or .web)

Files:

  • src/kernels/deepnote/types.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Inject interfaces, not concrete classes
Avoid circular dependencies
Use l10n.t() for user-facing strings
Use typed error classes from src/platform/errors/ when throwing or handling errors
Use the ILogger service instead of console.log
Preserve error details while scrubbing PII in messages and telemetry
Include the Microsoft copyright header in source files
Prefer async/await and handle cancellation with CancellationToken

Files:

  • src/kernels/deepnote/types.ts
src/kernels/**/*.ts

📄 CodeRabbit inference engine (.github/instructions/kernel.instructions.md)

src/kernels/**/*.ts: Use event-driven updates (EventEmitter) for state changes
Monitor and dispose pending promises to prevent leaks during teardown
Use WeakRef/weak references for notebook/object backreferences to avoid memory leaks
Respect CancellationToken in all async operations

Files:

  • src/kernels/deepnote/types.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & Test
🔇 Additional comments (1)
src/kernels/deepnote/types.ts (1)

159-159: Verify that deepnote-toolkit v1.0.0 exists on PyPI before merging.

The constant is changed from '1.0.0rc2' to '1.0.0' and used with exact version pinning (deepnote-toolkit[server]==1.0.0) in two installer files. Web search couldn't conclusively confirm v1.0.0 exists on PyPI—while the package page loads with JavaScript enabled, search engines can't index version details. The codebase usage is consistent across deepnoteToolkitInstaller.node.ts and deepnoteSharedToolkitInstaller.node.ts, including venv path generation and pip install commands. Ensure the stable release is actually published to PyPI before deployment, as installation will fail if this version doesn't exist.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73%. Comparing base (d330fd3) to head (f44c0c8).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #157   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        552     552           
  Lines      44264   44264           
  Branches    5313    5313           
=====================================
  Hits       32498   32498           
  Misses     10003   10003           
  Partials    1763    1763           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saltenasl saltenasl merged commit 58c86b6 into main Nov 2, 2025
13 checks passed
@saltenasl saltenasl deleted the mb/upgrade-toolkit-to-v1-from-rc branch November 2, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants