Skip to content

Conversation

@FilipPyrek
Copy link
Member

@FilipPyrek FilipPyrek commented Nov 3, 2025

Introduce support for Python 3.13

Toolkit release: https://github.com/deepnote/deepnote-toolkit/releases

Summary by CodeRabbit

  • Chores
    • Updated toolkit version to 1.1.0.

@FilipPyrek FilipPyrek requested a review from a team as a code owner November 3, 2025 18:24
@linear
Copy link

linear bot commented Nov 3, 2025

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

📝 Walkthrough

Walkthrough

Version number update for the Deepnote toolkit. The exported constant DEEPNOTE_TOOLKIT_VERSION is incremented from '1.0.0' to '1.1.0' in src/kernels/deepnote/types.ts. No runtime logic, error handling, or behavioral changes introduced.

Possibly related PRs

Suggested reviewers

  • andyjakubowski
  • saltenasl
  • Artmann

Pre-merge checks

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title directly describes the main change: updating DEEPNOTE_TOOLKIT_VERSION from 1.0.0 to 1.1.0.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 90bfefd and 6b32752.

📒 Files selected for processing (1)
  • src/kernels/deepnote/types.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/kernels/**/*.ts

📄 CodeRabbit inference engine (.github/instructions/kernel.instructions.md)

src/kernels/**/*.ts: Use event-driven updates (EventEmitter) for state changes
Monitor and dispose pending promises to prevent leaks during teardown
Use WeakRef/weak references for notebook/object backreferences to avoid memory leaks
Respect CancellationToken in all async operations

Files:

  • src/kernels/deepnote/types.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & Test
🔇 Additional comments (1)
src/kernels/deepnote/types.ts (1)

159-159: Code change verified and correct.

All usages of DEEPNOTE_TOOLKIT_VERSION in the codebase are consistent with the update to 1.1.0. The constant is properly used for:

  • Versioned virtual environment paths
  • Installation logging
  • pip install command (deepnote-toolkit[server]==1.1.0)

Since deepnote-toolkit is a Python package installed via pip (not an npm dependency), no package.json updates are required.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73%. Comparing base (7277539) to head (29d3cf1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #165   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        552     552           
  Lines      44525   44525           
  Branches    5318    5318           
=====================================
  Hits       32754   32754           
  Misses     10004   10004           
  Partials    1767    1767           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saltenasl saltenasl enabled auto-merge (squash) November 3, 2025 19:08
@saltenasl saltenasl merged commit 07f9044 into main Nov 3, 2025
13 checks passed
@saltenasl saltenasl deleted the fpyrek/blu-5114-bump-toolkit-version-in-the-extension-to-110 branch November 3, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants