Skip to content

Feat/cross validation #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
voorhs merged 54 commits into from
Feb 10, 2025
Merged

Feat/cross validation #121

voorhs merged 54 commits into from
Feb 10, 2025

Conversation

@voorhs
Copy link
Collaborator

@voorhs voorhs commented Feb 6, 2025 •
edited
Loading

  • можно выбирать между кросс-валидацией и холдаут-валидацией
  • можно делать ретрейн на всех данных после того как весь пайплайн сконфигурирован
  • убрал regexp (временно, мешалось)
  • скоринговые и ретривные метрики теперь игнорируют OOS примеры если они попались (это нужно было для корректной работы кросс-валидации)

voorhs added 30 commits February 1, 2025 12:03
@voorhs
define interface
8019153
@voorhs
basic ho iterator
90af5ce
@voorhs
move obtaining data for train from node optimizer to modules themselves
8601678
@voorhs
stage progress
ccf6e41
@voorhs
implement cv iterator
a307fee
@voorhs
minor bug fix
8649e14
@voorhs
implement cv iterator for decision node
a300f19
@voorhs
move cv iteration to base module definition
815561f
@voorhs
implement cv iterator for embedding node
f3ef812
@voorhs
add training to score_ho of each node
593744a
@voorhs
properly define base module
6fa0b24
@voorhs
fix codestyle
278855c
@voorhs
remove regexp node
bf9074f
@voorhs
remove regexp validator
8f30ec9
@voorhs
fix typing problems (except DataHandler._split_cv)
b2c8986
@voorhs
add ingore oos decorator
e24bde4
@voorhs
fix codestyle
a74e5dd
@voorhs
fix typing
8b94741
@voorhs
add oos handling to cv iterator
cfb2f25
@voorhs
remove DataHandler.dump()
e1d41a9
@voorhs
minor bug fix
9668dc6
@voorhs
implement splitting to cv folds
61130bb
@voorhs
fix codestyle
3084718
@voorhs
remove regex tests
ae13834
@voorhs
bug fix
4c49809
@voorhs
bug fix
2f8642f
@voorhs
update tests
13e63d1
@voorhs
fix typing
5ac89db
@voorhs
big fix
d4bf50f
@voorhs
basic test on cv folding
74dcb98
@voorhs voorhs marked this pull request as draft February 6, 2025 12:12
voorhs
voorhs commented Feb 6, 2025
View reviewed changes
Copy link
Collaborator Author

@voorhs voorhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

чек

@voorhs voorhs marked this pull request as ready for review February 6, 2025 13:00
@voorhs voorhs requested a review from Samoed February 6, 2025 13:02
Samoed
Samoed reviewed Feb 6, 2025
View reviewed changes
Samoed
Samoed reviewed Feb 6, 2025
View reviewed changes
Samoed
Samoed reviewed Feb 6, 2025
View reviewed changes
Samoed
Samoed reviewed Feb 7, 2025
View reviewed changes
@voorhs voorhs requested a review from Samoed February 10, 2025 15:36
Samoed
Samoed approved these changes Feb 10, 2025
View reviewed changes
@voorhs voorhs merged commit 0979234 into dev Feb 10, 2025
22 checks passed
@voorhs voorhs deleted the feat/cross-validation branch February 10, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Samoed Samoed Samoed approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@voorhs @Samoed