Refactor datasets logic #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voorhs
reviewed
Nov 12, 2024
voorhs
reviewed
Nov 12, 2024
voorhs
reviewed
Nov 12, 2024
Collaborator
voorhs
left a comment
voorhs
left a comment
There was a problem hiding this comment.
найс! можно продолжить работу в этом направлении
мне больше всего нравится что тут поддерживаются сплиты на трейн тест вал
voorhs
reviewed
Nov 20, 2024
Collaborator
voorhs
left a comment
voorhs
left a comment
There was a problem hiding this comment.
осталось добавить валидацию и пуш в hf hub
Comment on lines
+32
to
+33
| if self.dataset.multilabel: | ||
| self.dataset = self.dataset.encode_labels() |
Collaborator
There was a problem hiding this comment.
эти действия никак не вставить на этап загрузки датасета?
Samoed
approved these changes
Nov 20, 2024
voorhs
approved these changes
Nov 25, 2024
Collaborator
voorhs
left a comment
voorhs
left a comment
There was a problem hiding this comment.
Кажется надо удалить файл autointent/context/data_handler/scheme.py и соседние ему multilabel_generation.py и sampling.py. Они не используется и при этом вызывают ошибки тайпинга.
Плюс надо прогнать форматтер make lint
Еще я сейчас обнаружил что у нас есть целая фича не покрытая тестами: Tags. Надо будет заняться этим до релиза
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.