Replies: 4 comments
|
Your diagnosis looks correct. Since The fact that Moving both packages to So I agree with the proposed fix; this looks like a packaging/dependency classification issue rather than a TypeScript configuration problem. |
|
Confirmed independently, two ways. Read packages/llm/llm/package.json on current master directly: both @deepseek-ai/dsh-attachment and @deepseek-ai/dsh-invariants really are under devDependencies, sitting right next to @deepseek-ai/cordis (which is correctly there since it's already a peerDependency). And I ran npm view @deepseek-ai/dsh-llm@0.1.3-alpha.2 dependencies --json myself just now against the live registry, not just reading source, same result: only zod, dsh-brand, dsh-timeout, schemastery, dsh-util-crypto, dsh-util-values, dsh-typert-protocol show up. No dsh-attachment, no dsh-invariants. So this is live and broken right now, not something already fixed since your report or a one-off tarball glitch. Also checked the exports field, since that settles whether ./invariant is really public API or something more internal: it's a real subpath export, "./invariant": { "types": "./lib/types/invariant.d.ts", "default": "./lib/invariant.js" }, published right alongside the main entry. So InvariantFailure/InvariantInstaller aren't reachable through some undocumented internal path, they're behind an explicitly published entry point, which makes the devDependencies placement unambiguous, not a borderline call. Your fix (move both to dependencies) is the correct and minimal one. Good idea pushing a reference branch given CONTRIBUTING.md doesn't take PRs right now, that gives a maintainer a diff to just apply rather than rederive. |
Update: still open, live-broken as of today, two independent confirmationsConfirming this is still reproducible right now against the current registry and current Two independent confirmations so far, both verified against source and the live registry:
I attempted to open this as a formal PR so there'd be a reviewable diff + CI, but PR creation against this repo appears to be fully disabled at the platform level (not just unreviewed — master...musichen:deepseek-harness:fix/dsh-llm-attachment-invariants-dependencies It's a 2-file, 4-line manifest change ( Tagging a few of the most active contributors on this repo in case it helps surface this for triage, per the guidance in |
Additional visibilityWidening the cc to more of the repo's most active contributors, in case anyone here owns packaging/publishing for @tianyicui @LegGasai @Chinesezjc @kermanx @CreatixChu @turtle1999 @pku-xht @ZiyaZhang @Kingwl @Dudu-0223 @Elevator14B @NI0317 For anyone landing here fresh: this is a 2-file, 4-line master...musichen:deepseek-harness:fix/dsh-llm-attachment-invariants-dependencies |
Uh oh!
There was an error while loading. Please reload this page.
Summary
@deepseek-ai/dsh-llm's public type surface imports directly from both@deepseek-ai/dsh-attachmentand@deepseek-ai/dsh-invariants:FileAttachmentRef/ImageAttachmentReffromdsh-attachmentinsrc/index.ts,src/content.ts, andsrc/types.tsInvariantFailure/InvariantInstallerfromdsh-invariantsinsrc/invariant.ts, which backs the package's own published./invariantsubpath exportBoth are declared under
devDependenciesinpackages/llm/llm/package.jsoninstead ofdependencies.devDependenciesnever ship in a published npm tarball, so any consumer resolvingdsh-llm's types underNodeNext/bundlermodule resolution hitsTS2724: has no exported memberonFileAttachmentRef(and would hit the same onInvariantFailure/InvariantInstallerfor the./invariantsubpath).@deepseek-ai/cordiscorrectly stays indevDependenciessince it's already declared as apeerDependency— this is specifically about the two that aren't peers.Repro
Hit while upgrading a downstream consumer from
@deepseek-ai/dsh-llm@0.1.1-rc.2to0.1.3-alpha.2.Suggested fix
Move both entries from
devDependenciestodependenciesinpackages/llm/llm/package.json. I verified locally thatpnpm packthen correctly includes both in the tarball'sdependenciesat^0.1.3-alpha.2.Since I understand external PRs aren't being accepted right now, I've pushed the verified fix (4-line package.json change + regenerated lockfile) on a branch here in case it's useful as a reference: https://github.com/musichen/deepseek-harness/tree/fix/dsh-llm-attachment-invariants-dependencies
All reactions