pnpm run clean fails on v0.1.7-rc.2: "expected TypeScript outDir to end in /types: lib/desktop-keyboard-test-types"

[GrigK]

Clean script fails on a fresh rc.2 checkout

Version: tag dsh-v0.1.7-rc.2 (477b4f4), clean checkout, pnpm install done. pnpm 11.7, Node 22.20.

Repro:

$ pnpm run clean
clean: expected TypeScript outDir to end in /types: lib/desktop-keyboard-test-types
[ELIFECYCLE] Command failed with exit code 1.

Cause: tsconfig.desktop-keyboard-tests.json (added in 6a82709) declares "outDir": "lib/desktop-keyboard-test-types" (emitDeclarationOnly keyboard-test fixture) and is reachable from the root project-reference graph via tsconfig.client.json. scripts/clean.ts buildOutputDirectories() accepts only two forms of outDir: basename types, or the native entry output — any other name throws.

So on every fresh rc.2 checkout pnpm run clean is broken (and stale lib/ from a previous version cannot be cleaned by the script — the exact scenario clean exists for).

Expected: the planner either removes this outDir as well (deleting lib/desktop-keyboard-test-types), or has an allowlist for test-fixture outDirs.

Workaround: manually remove gitignored lib/ directories plus root-level *.tsbuildinfo (replicating the clean plan by hand), then pnpm run build succeeds (exit 0, 343 client artifacts).

[JulienKervarrec]

This is fixed on master by a08472e ("fix(build): fold desktop keyboard tests into client typecheck"). It deletes tsconfig.desktop-keyboard-tests.json and moves those files into the tsconfig.client.json typecheck, so the only outDir left in the project graph that doesn't end in /types is the native entry lib, which scripts/clean.ts already special-cases. The commit shipped in dsh-v0.2.0-rc.1 (tagged yesterday).

Checked on a fresh clone:

$ git checkout dsh-v0.1.7-rc.2 && pnpm run clean
clean: expected TypeScript outDir to end in /types: lib/desktop-keyboard-test-types   # exit 1
$ git checkout dsh-v0.2.0-rc.1 && pnpm run clean
clean: already clean                                                                   # exit 0

If you need to stay on rc.2, the fix cherry-picks cleanly and clean exits 0 afterwards:

git cherry-pick a08472e982
pnpm run clean

One leftover to know about: once the config is gone, clean no longer knows about lib/desktop-keyboard-test-types. So if an rc.2 build already emitted it, it survives pnpm run clean (I checked: the folder is still there after an "already clean" run). Delete that one folder by hand once:

rm -rf lib/desktop-keyboard-test-types   # PowerShell: Remove-Item -Recurse -Force lib\desktop-keyboard-test-types

[GrigK]

Thanks @JulienKervarrec — clear and actionable.

We run rc.2 in production with the documented workaround (manual lib/ + *.tsbuildinfo cleanup after builds), so we will pick up a08472e with our next pin bump rather than cherry-picking mid-wave. Good to know the already-emitted lib/desktop-keyboard-test-types survives clean even after the fix — that matches what we saw on our checkout and our workaround covers it.

Marking your comment as the answer.