Skip to content

test: type check more component tests - #12097

Draft
zcxGGmu wants to merge 1 commit into
deepset-ai:mainfrom
zcxGGmu:test/10396-type-check-small-components
Draft

test: type check more component tests#12097
zcxGGmu wants to merge 1 commit into
deepset-ai:mainfrom
zcxGGmu:test/10396-type-check-small-components

Conversation

@zcxGGmu

@zcxGGmu zcxGGmu commented Jul 21, 2026

Copy link
Copy Markdown

Summary

  • Add test/components/query/, test/components/tools/, and test/components/validators/ to the test:types target.
  • Keep the scope small and avoid test/components/embedders/, which was already claimed in the issue thread.
  • No runtime behavior changes.

Refs #10396

Testing

  • hatch -e test run mypy --python-version 3.13 --install-types --non-interactive --cache-dir=.mypy_cache/ test/components/query/ test/components/tools/ test/components/validators/
  • hatch -e test run mypy --python-version 3.13 --install-types --non-interactive --cache-dir=.mypy_cache/ haystack test/core/ test/marshal/ test/testing/ test/tracing/ test/tools/ test/hooks/human_in_the_loop test/evaluation test/document_stores test/dataclasses test/utils/ test/components/embedders/ test/components/query/ test/components/tools/ test/components/validators/
  • git diff --check

@zcxGGmu
zcxGGmu requested a review from a team as a code owner July 21, 2026 10:54
@zcxGGmu
zcxGGmu requested review from anakin87 and removed request for a team July 21, 2026 10:54
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

@MaskerFather is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @zcxGGmu, thanks for your interest in contributing to Haystack! 🙏

⚠️ You currently have 3 open pull requests in this repository (#12095, #12092 and this one). Our review capacity is limited, so please hold off opening more PRs until we've had a chance to review your first 2 open PRs. This helps us give each contribution the attention it deserves. Thank you!

This is an automated message to help us keep the review queue healthy.

@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @zcxGGmu, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from anakin87 July 21, 2026 11:56
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Jul 21, 2026
@HaystackBot
HaystackBot marked this pull request as draft July 21, 2026 11:56
@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @zcxGGmu, just a friendly reminder: this PR is still in draft because the Contributor License Agreement (CLA) hasn't been signed yet. We'd love to review your contribution! Please sign the CLA via the link in the license/cla check, and this PR will automatically be marked ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-pending PR is in draft until the contributor signs the CLA topic:build/distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants