fix: accept zero hierarchy meta values in AutoMergingRetriever - #12635
Merged
Conversation
HierarchicalDocumentSplitter stores __level=0 and __block_size=0 on the root. Validation must check key presence, not truthiness.
|
@coder058 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
AutoMergingRetriever._check_valid_documentsvalidated__leveland__block_sizewith truthiness (doc.meta.get(...)), so a present value of0was treated as missing.HierarchicalDocumentSplitterintentionally stores__level=0and__block_size=0on the root document. Validation now checks key presence (__level in doc.meta) instead of truthiness.__parent_id` still requires a truthy value because leaves must point at a parent.How did you test it?
test_run_accepts_zero_level_and_block_size.ValueError: ... '__level').hatch -e test run pytest test/components/retrievers/test_auto_merging_retriever.py→ 20 passed.Notes for the reviewer
_check_valid_documents(shared by sync and async paths).Checklist
fix:This PR was fully generated with an AI assistant. I have reviewed the changes and run the relevant tests.