refactor: update package strategy in rest_api#3148
Merged
Conversation
agnieszka-m
approved these changes
Sep 5, 2022
ZanSara
suggested changes
Sep 5, 2022
Contributor
ZanSara
left a comment
ZanSara
left a comment
There was a problem hiding this comment.
Looks good 👍
Overall I found only a few links to fix, one minor question mark, and I'm super interested about __about__.py for some reason 😄
| Source = "https://github.com/unknown/rest-api" | ||
|
|
||
| [tool.hatch.version] | ||
| path = "rest_api/__about__.py" |
Contributor
There was a problem hiding this comment.
Wow, this is new!
I've googled it quickly and found some references in SO, but no official docs. Is it a style choice or something actually recommended for packages? I like it, and if it's a standard I'd like to see it in Haystack as well someday in place of the VERSION.txt file 🤩
Contributor
Author
There was a problem hiding this comment.
I don't think it's standard but it looks like a good practice. I got it from the default template used by hatch when you bootstrap a new project, it can be definitely ported to Haystack at some point
6 tasks
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Part of: #3085
At this moment it's not possible to install
rest_uiunless it's in editable mode, which prevents optimising Haystack's Dockerfiles.Proposed Changes:
Refactor the packaging so that
rest_apican be properly installedHow did you test it?
pip install /path/to/haystack-repo/rest_apiNotes for the reviewer
Checklist