refactor: update package strategy in ui#3396
refactor: update package strategy in ui#3396ZanSara merged 14 commits intodeepset-ai:mainfrom anakin87:update_package_ui
Conversation
|
| RUN mkdir ui/ | ||
| COPY . /opt/ui | ||
| COPY . /ui | ||
|
|
||
| # install as a package | ||
| RUN pip install --upgrade pip && \ | ||
| pip install /opt/ui/ | ||
| pip install /ui/ | ||
|
|
||
| WORKDIR /opt |
There was a problem hiding this comment.
Just curious here, there was a specific reason to move /ui out of /opt?
There was a problem hiding this comment.
No particular reason.
I tried to clean and simplify the Dockerfile.
If it's not desirable, I can easily revert this change!
There was a problem hiding this comment.
No no, that's all right 👍 I'll tag @masci just in case but I don't see an issue here.
There was a problem hiding this comment.
Not a big deal, /opt is just a convention (albeit a very widespread one 😅)
ZanSara
left a comment
There was a problem hiding this comment.
Glad this new version is working! Thank you for all the work 😊
Related Issues
rest_apiandui#3085Proposed Changes:
Similarly to #3148, I'm trying to update package strategy in ui
How did you test it?
pip install /path/to/haystack-repo/uiNotes for the reviewer
It's just a first try. @masci @ZanSara feel free to guide me...
Checklist