feat: FAISS in OpenSearch: Support HNSW for cosine #3217
Merged
Conversation
This reverts commit 6138fdf.
tstadel
commented
Sep 14, 2022
tstadel
commented
Sep 14, 2022
tstadel
commented
Sep 14, 2022
tstadel
commented
Sep 14, 2022
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
6 tasks
bogdankostic
approved these changes
Sep 22, 2022
Contributor
bogdankostic
left a comment
There was a problem hiding this comment.
There seem to be some conflicts, otherwise LGTM! Also, I added a comment wrt #3102
| # global ef_search setting affects only nmslib, for faiss it is set in the field mapping | ||
| if self.index_type == "hnsw": | ||
| if self.knn_engine == "nmslib" and self.index_type == "hnsw": | ||
| index_definition["settings"]["index"]["knn.algo_param.ef_search"] = 20 |
Contributor
There was a problem hiding this comment.
This is probably out of scope for this PR, just a reminder that at some point we should probably allow to set custom values for ef_search (see also #3102)
agnieszka-m
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
pushed to another PR:
BaseDocumentStore_validate_embeddings_shape)DenseRetrieverabstraction to facilitate usage of retrievers in document store'supdate_embeddingsHow did you test it?
test_cosine_similarityoftest_faiss_and_milvus.pygeneric to run on all document storesNotes for the reviewer
Checklist