Conversation
This reverts commit 6138fdf.
tstadel
added
breaking change
type:refactor
ZanSara
suggested changes
Sep 21, 2022
Contributor
ZanSara
left a comment
ZanSara
left a comment
There was a problem hiding this comment.
Super cool! I'm really happy for this change 🤩 There is one "big" question we might want to address, the other are smaller notes. Thank you for taking care of this!
6 tasks
This reverts commit 83cf8f3.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
update_embeddings(see feat: FAISS in OpenSearch: Support HNSW for cosine #3217): get rid of # type: ignoreBaseRetrieverdeepcopies all documents at indexing #3242Proposed Changes:
DenseRetrieverabstraction to facilitate usage of retrievers in document store'supdate_embeddingsBaseDocumentStore_validate_embeddings_shape)Breaking Changes:
DensePassageRetrieverandEmbeddingRetriever:embed_queries's arg changed fromtextstoqueriesHow did you test it?
Notes for the reviewer
Checklist