Use Gradle zip task for binary copy and preserve permissions - #92
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes packaging of the Kotlin/Native release binaries by switching from a custom ZipOutputStream implementation to Gradle’s built-in Zip task, enabling filesystem permission preservation so Linux (and macOS) binaries keep their executable bit when extracted.
Changes:
- Replaces the single custom
MakeBinariesZipTaskwith per-target GradleZiptasks. - Enables
useFileSystemPermissions()on the produced archives and keeps a consistent output location/name scheme. - Removes the now-unused custom zipping task implementation from
buildSrc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cli/build.gradle.kts |
Creates per-target Zip tasks that zip the produced binaries while preserving filesystem permissions (fixing the missing executable bit issue). |
buildSrc/src/main/kotlin/com/deezer/caupain/tasks/MakeBinariesZipTask.kt |
Deletes the custom zipping task that didn’t preserve executable permissions in the resulting zip entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix zip of release binaries by using Gradle zip task and preserving permissions
Issue number, if applicable
FIxes #91
Checklist
./gradlew check.