Fixed an issue where a 16k x 16k atlas couldn’t be unpacked if the file size was bigger than 1 GB #11058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGulev
commented
Aug 6, 2025
| dmLZ4::Result r = dmLZ4::DecompressBuffer(source_data, source_data_size, buffer, size, &decompressed_size); | ||
| if (dmLZ4::RESULT_OK != r) | ||
| { | ||
| dmLogError("LZ4 decompression failed: result=%d, expected size=%u, actual size=%d", r, size, decompressed_size); |
britzl
previously approved these changes
Aug 7, 2025
AGulev
commented
Aug 7, 2025
| Result DecompressBuffer(const void* buffer, uint32_t buffer_size, void* decompressed_buffer, uint32_t max_output, int* decompressed_size) | ||
| { | ||
| Result r; | ||
| // When we set an output size larger than 1G (or closer to 2G) lz4 fails for some reason... |
There was a problem hiding this comment.
not true anymore, but I left limit with another comment
britzl
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1 GB limitation for compressed files was doubled to make it possible to work with 16k x 16k atlases.
Fix #10404