Make aspect ratio–related function in the camera.* module useful
#11077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGulev
commented
Aug 10, 2025
| {"get_orthographic_zoom", RenderScriptCamera_GetOrthographicZoom}, | ||
| {"set_orthographic_zoom", RenderScriptCamera_SetOrthographicZoom}, | ||
| {"get_auto_aspect_ratio", RenderScriptCamera_GetAutoAspectRatio}, | ||
| {"set_auto_aspect_ratio", RenderScriptCamera_SetAutoAspectRatio}, |
There was a problem hiding this comment.
I though initially that it should be is_auto_aspect_ration because this is a checkbox? as in gui: https://defold.com/ref/gui/#gui.is_enabled:node-recursive
But then a conversation poped up in my head that when I implemented https://defold.com/ref/gui/#gui.get_visible:node
we agree that we always use get, and this is_ in gui is the only place
| /*# get aspect ratio | ||
| * Gets the effective aspect ratio of the camera. If auto aspect ratio is enabled, | ||
| * returns the aspect ratio calculated from the current render target dimensions. | ||
| * Otherwise returns the manually set aspect ratio. |
There was a problem hiding this comment.
better explanation what it returns
britzl
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in APIs:
camera.get_aspect_ratio()– Now returns the effective aspect ratio (auto-calculated if auto is enabled, manual value if disabled)camera.set_aspect_ratio()– Sets the manual aspect ratio value, which is used only if auto is disabledcamera.get_auto_aspect_ratio()– Returns whether auto-calculation is enabledcamera.set_auto_aspect_ratio()– Controls whether to use auto-calculation or the manual valueFix #10632