Enable go.exists() to query the existence of game objects across collections
#11083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGulev
commented
Aug 11, 2025
| // Same collection - use current collection | ||
| target_instance = dmGameObject::GetInstanceFromIdentifier(dmGameObject::GetCollection(instance), target.m_Path); | ||
| } | ||
| else |
| if pcall(go.exists, "foo:/bar") then | ||
| assert(false, "Error expected when calling go.exists with another collection") | ||
| end | ||
| assert(not go.exists("foo:/bar"), "Expected go 'foo:/bar' (non-existent collection) to not exist") |
There was a problem hiding this comment.
Old test can check only negative case, I added a new one for positive case
| if message_id == hash("proxy_loaded") then | ||
| if self.test_phase == "loading" then | ||
| self.test_phase = "testing" | ||
| msg.post("#target_proxy", "enable") |
There was a problem hiding this comment.
Setup to test all the go.exist() cases including inter-collection checking
britzl
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, it will be possible to use the
go.exists()function to check if a game object exists in another collection.Fix #10795