Skip to content

Comments

Fixing typos in COWL specification#1

Closed
jonathanKingston wants to merge 2 commits intodeian:cowlfrom
jonathanKingston:cowl-typos
Closed

Fixing typos in COWL specification#1
jonathanKingston wants to merge 2 commits intodeian:cowlfrom
jonathanKingston:cowl-typos

Conversation

@jonathanKingston
Copy link

@deian little nervous about the number of changes bikeshed has made here however some of the references have changed due to typos so that could be it.

Let me know if there is any issue with this etc.

@jonathanKingston
Copy link
Author

I'm going to push error fixes for bikeshed next; I'll add to this pull I think.

@deian
Copy link
Owner

deian commented Sep 5, 2015

@jonathanKingston thanks! I should've given you a heads up since I was just prepping this for a PR, but got stuck without wifi on my flight to europe. I've been addressing the bikeshed errors, rebasing and squashing everything. I'll merge everything on top of this.

@jonathanKingston
Copy link
Author

@deian yeah sorry I have not replied to your mail either; I figured you were busy on holiday or something :D.

I hope this isn't going to be a nightmare to merge together sorry. (It was worthwhile for me whilst I was reading the spec anyway)

@jonathanKingston
Copy link
Author

I just pushed the bikeshed fixes, I can remove that one if it is a pain to fix the merge there (It may straight merge over the top though as it's only white space mostly).

@deian
Copy link
Owner

deian commented Sep 5, 2015

Thanks. I'm just merging these manually since I fixed some types on the flight as well. Do you happen to remember the fix for these 2?

FATAL ERROR: No 'idl-name' refs found for 'FreshPrivilege'.
FATAL ERROR: No 'idl-name' refs found for 'object'

@jonathanKingston
Copy link
Author

@deian I didn't get round to fixing those, just the ones at the top for markdown syntax errors. My webidl isn't great still :(

Looks to me like object should be ignored from this: speced/bikeshed#381

The other looks like it needs to be defined here:

<pre class="idl">
      interface FreshPrivledge {
      }

      [Constructor, NamedConstructor=FreshPrivilege, Exposed=Window, Worker]

@deian
Copy link
Owner

deian commented Sep 5, 2015

Alright. All done. Thank you so much for this!
w3c#466

@deian deian closed this Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants