Skip to content

Fix the closer channel in pkg/sshd/server.go #322

@arschles

Description

@arschles

Summary

There is a chan interface{} in pkg/sshd/server.go that acts as a sentinel channel. It is, however, checked in the event loop that accepts incoming socket connections like so:

if len(closer) > 0 {
    <-closer
    // ...
   return nil
}

Above the for, this comment exists: // FIXME: Since Accept blocks, closer may not be checked often enough.. If the closer channel is still needed, that FIXME comment should be addressed.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions