This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(release): during cleanup let pod deletion 404 in case Kubernetes cleaned up as well#1005
Merged
helgi merged 1 commit intodeis:masterfrom Aug 23, 2016
Merged
fix(release): during cleanup let pod deletion 404 in case Kubernetes cleaned up as well#1005helgi merged 1 commit intodeis:masterfrom
helgi merged 1 commit intodeis:masterfrom
Conversation
|
@kmala, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of |
…cleaned up as well Fixes deis#1002
Current coverage is 86.11% (diff: 27.27%)@@ master #1005 diff @@
==========================================
Files 28 28
Lines 3167 3175 +8
Methods 0 0
Messages 0 0
Branches 538 540 +2
==========================================
Hits 2734 2734
- Misses 287 295 +8
Partials 146 146
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is very hard to write tests for so leaving that off for now.
Fixes #1002