Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

docs(CONTRIBUTING): update contributing doc#1006

Merged
Joshua-Anderson merged 1 commit intodeis:masterfrom
Joshua-Anderson:contributing
Aug 25, 2016
Merged

docs(CONTRIBUTING): update contributing doc#1006
Joshua-Anderson merged 1 commit intodeis:masterfrom
Joshua-Anderson:contributing

Conversation

@Joshua-Anderson
Copy link
Copy Markdown
Contributor

No description provided.

@deis-bot
Copy link
Copy Markdown

@krancour, @bacongobbler and @carmstrong are potential reviewers of this pull request based on my analysis of git blame information. Thanks @Joshua-Anderson!

@codecov-io
Copy link
Copy Markdown

Current coverage is 86.14% (diff: 100%)

Merging #1006 into master will increase coverage by 0.03%

@@             master      #1006   diff @@
==========================================
  Files            28         28          
  Lines          3175       3175          
  Methods           0          0          
  Messages          0          0          
  Branches        540        540          
==========================================
+ Hits           2734       2735     +1   
+ Misses          295        294     -1   
  Partials        146        146          

Powered by Codecov. Last update bff6d60...5d2cd10

@helgi
Copy link
Copy Markdown
Contributor

helgi commented Aug 24, 2016

The deis.com doc is missing the DCO (do we care about that anymore?) and linking to troubleshooting, among other things.

@Joshua-Anderson
Copy link
Copy Markdown
Contributor Author

The DCO is in a filed called DCO in the project root.

Should we link to troubleshooting in contributing docs?
Is there somewhere else you would rather link?

@helgi
Copy link
Copy Markdown
Contributor

helgi commented Aug 24, 2016

The contributing guide was caking out the DCO and semi explained it - otherwise I would have never known what it was

@helgi
Copy link
Copy Markdown
Contributor

helgi commented Aug 24, 2016

Probably enough to link to the troubleshooting docs - gets it into more hands

@Joshua-Anderson
Copy link
Copy Markdown
Contributor Author

@helgi Would you like me to add back:

By contributing to any Deis project you agree to its [Developer Certificate of Origin (DCO)][dco]. This document was created by the Linux Kernel community and is a simple statement that you, as a contributor, have the legal right to make the contribution.

to the document?

@helgi
Copy link
Copy Markdown
Contributor

helgi commented Aug 24, 2016

Figured that could be added to the website

@Joshua-Anderson
Copy link
Copy Markdown
Contributor Author

Ok, I'll make a PR to the docs adding mentioning the DCO and adding a link to troubleshooting to the page.

@Joshua-Anderson Joshua-Anderson merged commit 757a8ae into deis:master Aug 25, 2016
@Joshua-Anderson Joshua-Anderson deleted the contributing branch August 25, 2016 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants