This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(models): add "_added" log function, lowercase class name#1017
Merged
bacongobbler merged 1 commit intodeis:masterfrom Aug 26, 2016
Merged
fix(models): add "_added" log function, lowercase class name#1017bacongobbler merged 1 commit intodeis:masterfrom
bacongobbler merged 1 commit intodeis:masterfrom
Conversation
|
@helgi, @mboersma and @kmala are potential reviewers of this pull request based on my analysis of |
bacongobbler
force-pushed
the
lowercase-class-name
branch
from
a15c112 to
c300883
Compare
Current coverage is 86.68% (diff: 100%)@@ master #1017 diff @@
==========================================
Files 29 29
Lines 3282 3282
Methods 0 0
Messages 0 0
Branches 555 555
==========================================
Hits 2845 2845
Misses 288 288
Partials 149 149
|
Contributor
This change caused e2e to fail because it expects the class name to be lower case.
bacongobbler
force-pushed
the
lowercase-class-name
branch
from
c300883 to
22800b2
Compare
bacongobbler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change caused e2e to fail because it expects the class name to be lower case.