This repository was archived by the owner on May 6, 2020. It is now read-only.
ref(scheduler): add HTTP functions in KubeHTTPClient#1019
Merged
bacongobbler merged 1 commit intodeis:masterfrom Sep 9, 2016
Merged
ref(scheduler): add HTTP functions in KubeHTTPClient#1019bacongobbler merged 1 commit intodeis:masterfrom
bacongobbler merged 1 commit intodeis:masterfrom
Conversation
|
@helgi is a potential reviewer of this pull request based on my analysis of |
bacongobbler
force-pushed
the
1008-use-generic-session-methods
branch
from
185c229 to
03c1d25
Compare
Current coverage is 86.83% (diff: 79.74%)@@ master #1019 diff @@
==========================================
Files 42 41 -1
Lines 3565 3509 -56
Methods 0 0
Messages 0 0
Branches 607 578 -29
==========================================
- Hits 3097 3047 -50
+ Misses 309 307 -2
+ Partials 159 155 -4
|
Contributor
|
Awesome, wonder if we should handle the Btw this can go into 2.5 since it was delayed. |
| # ensure that connection errors get raised as a KubeException | ||
| self.adapter.add_matcher(connection_refused_matcher) | ||
| with self.assertRaises(exceptions.KubeException): | ||
| self.scheduler.http_head(self.path) |
Contributor
There was a problem hiding this comment.
Should this be http_head when it is in test_get?
Member
Author
There was a problem hiding this comment.
good catch. will fix
bacongobbler
force-pushed
the
1008-use-generic-session-methods
branch
3 times, most recently
from
a87b096 to
228e00c
Compare
these functions properly handle connection errors and clean up some of the child/parent class relations when making a request.
bacongobbler
force-pushed
the
1008-use-generic-session-methods
branch
from
228e00c to
fd95fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions properly handle connection errors and clean up some of the child/parent class
relations when making a request.
closes #1008