This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(certs): allow empty Common Name in certificates#1024
Merged
helgi merged 1 commit intodeis:masterfrom Aug 30, 2016
Merged
Conversation
|
@bacongobbler and @Joshua-Anderson are potential reviewers of this pull request based on my analysis of |
| key = models.TextField() | ||
| # X.509 certificates allow any string of information as the common name. | ||
| common_name = models.TextField(editable=False, unique=False) | ||
| common_name = models.TextField(editable=False, unique=False, null=True) |
Contributor
There was a problem hiding this comment.
does this require migration to be run?
Contributor
Author
There was a problem hiding this comment.
yeah it is in there now
Current coverage is 87.09% (diff: 100%)@@ master #1024 diff @@
==========================================
Files 41 41
Lines 3464 3464
Methods 0 0
Messages 0 0
Branches 578 578
==========================================
- Hits 3018 3017 -1
- Misses 291 292 +1
Partials 155 155
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1000