This repository was archived by the owner on May 6, 2020. It is now read-only.
feat(scheduler): use /scale endpoints for RC and Deployments to only update replicas during scale events#1029
Merged
helgi merged 1 commit intodeis:masterfrom Sep 1, 2016
Merged
Conversation
|
@kmala, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of |
Current coverage is 87.08% (diff: 81.81%)
|
helgi
force-pushed
the
scale_resource
branch
from
54cb968 to
4b695d5
Compare
…update replicas during scale events Prior to this a full resource update was being done during a scale event, this could lead to potential pod template updates that were not desired Fixes deis#1012
helgi
force-pushed
the
scale_resource
branch
from
4b695d5 to
c85e0b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this a full resource update was being done during a scale event, this could lead to potential pod template updates that were not desired
Fixes #1012