This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(app): create image pull secrets outside of the async deploy loop#1032
Merged
helgi merged 1 commit intodeis:masterfrom Sep 1, 2016
Merged
fix(app): create image pull secrets outside of the async deploy loop#1032helgi merged 1 commit intodeis:masterfrom
helgi merged 1 commit intodeis:masterfrom
Conversation
|
@kmala, @bacongobbler and @Joshua-Anderson are potential reviewers of this pull request based on my analysis of |
helgi
force-pushed
the
ticket_1031
branch
3 times, most recently
from
94ec7eb to
7e2a6e4
Compare
The issue is that multiple process types can cause 409 issues when ran in the async process. It's fine to run this ahead of any deploy as this secret is not tied to the release version of an application Moved pull image secret and registry config generation into the App model as it makes more sense given where it gets used. Also reduces `django.settings` in the `scheduler` Fixes deis#1031
Current coverage is 87.04% (diff: 92.59%)@@ master #1032 diff @@
==========================================
Files 42 42
Lines 3560 3567 +7
Methods 0 0
Messages 0 0
Branches 601 602 +1
==========================================
+ Hits 3098 3105 +7
Misses 302 302
Partials 160 160
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that multiple process types can cause 409 issues when ran in the async process. It's fine to run this ahead of any deploy as this secret is not tied to the release version of an application
Moved pull image secret and registry config generation into the App model as it makes more sense given where it gets used.
Also reduces
django.settingsin theschedulerFixes #1031