This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(logs): app logs endpoint was returning binary string instead of a normal string#1035
Merged
helgi merged 1 commit intodeis:masterfrom Sep 2, 2016
Merged
fix(logs): app logs endpoint was returning binary string instead of a normal string#1035helgi merged 1 commit intodeis:masterfrom
helgi merged 1 commit intodeis:masterfrom
Conversation
|
@bacongobbler, @Joshua-Anderson and @kmala are potential reviewers of this pull request based on my analysis of |
helgi
force-pushed
the
ticket_1033
branch
2 times, most recently
from
41ab787 to
9341bcd
Compare
Contributor
Author
|
Bumping the API Version as the SDK (and CLI, since beta) have been doing something like this https://github.com/deis/controller-sdk-go/blob/master/apps/apps.go#L110 Older clients are not going to be very compatible with the new [correct] output |
Current coverage is 87.04% (diff: 100%)@@ master #1035 diff @@
==========================================
Files 42 42
Lines 3567 3567
Methods 0 0
Messages 0 0
Branches 602 602
==========================================
Hits 3105 3105
Misses 302 302
Partials 160 160
|
… normal string When pythong-requests got data from logger it was in binary string format, converting that to normal string was sufficient Fixes deis#1033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When python-requests got data from logger it was in binary string format, converting that to normal string was sufficient
Docs change deis/workflow#485
Fixes #1033