This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(release): change release cleanup to only remove secrets related to Deployments that are no longer active#1038
Merged
helgi merged 1 commit intodeis:masterfrom Sep 2, 2016
Merged
Conversation
|
@kmala, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of |
Current coverage is 87.20% (diff: 25.00%)@@ master #1038 diff @@
==========================================
Files 42 42
Lines 3573 3540 -33
Methods 0 0
Messages 0 0
Branches 603 597 -6
==========================================
- Hits 3112 3087 -25
+ Misses 301 295 -6
+ Partials 160 158 -2
|
helgi
force-pushed
the
better_cleanup
branch
from
a8964ae to
83793e2
Compare
…o Deployments that are no longer active Before the cleanup proceess and Release::delete were removing RCs and env secrets related to all but current releases, this can (and has) gotten all screwy in the logic due to how RC and Deployment cleanup ended up being merged instead of being previously separate. Now the process it so cleanup non-latest RCs (just as a safety thing), and only remove secrets that are not associated to a specific ReplicaSet
helgi
force-pushed
the
better_cleanup
branch
from
83793e2 to
0a0b651
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the cleanup process and Release::delete were removing RCs and env secrets related to all but current releases, this can (and has) gotten all screwy in the logic due to how RC and Deployment cleanup ended up being merged instead of being previously separate.
Now the process it so cleanup non-latest RCs (just as a safety thing), and only remove secrets that are not associated to a specific ReplicaSet