Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

fix(api): create TLS object on app create#1043

Merged
bacongobbler merged 1 commit intodeis:masterfrom
bacongobbler:1042-create-tls-object-on-app-create
Sep 7, 2016
Merged

fix(api): create TLS object on app create#1043
bacongobbler merged 1 commit intodeis:masterfrom
bacongobbler:1042-create-tls-object-on-app-create

Conversation

@bacongobbler
Copy link
Copy Markdown
Member

This PR creates a TLS object when an application is created, fixing the issue where a server error is shown after deis tls:info is called after deis create.

closes #1042

@bacongobbler bacongobbler added this to the v2.5 milestone Sep 7, 2016
@bacongobbler bacongobbler self-assigned this Sep 7, 2016
@deis-bot
Copy link
Copy Markdown

deis-bot commented Sep 7, 2016

@helgi, @kmala and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

@bacongobbler bacongobbler force-pushed the 1042-create-tls-object-on-app-create branch from 6d487ed to be6e477 Compare September 7, 2016 21:20
@bacongobbler bacongobbler changed the title ref(scheduler): scheduler passes the kubernetes endpoint to resources… fix(api): create TLS object on app create Sep 7, 2016
@bacongobbler bacongobbler force-pushed the 1042-create-tls-object-on-app-create branch from be6e477 to 881022d Compare September 7, 2016 21:21
@helgi helgi added the LGTM1 label Sep 7, 2016
@bacongobbler bacongobbler force-pushed the 1042-create-tls-object-on-app-create branch from 881022d to 22f133f Compare September 7, 2016 21:35
@bacongobbler
Copy link
Copy Markdown
Member Author

With this fix:

><> deis create www --no-remote
Creating Application... done, created www
If you want to add a git remote for this app later, use `deis git:remote -a www`
><> deis tls -a www
=== www TLS
HTTPS Enforced: not set

This PR creates a TLS object when an application is created, fixing the issue where a server error
is shown after `deis tls:info` is called after `deis create`.
@bacongobbler bacongobbler force-pushed the 1042-create-tls-object-on-app-create branch from 22f133f to 8978d03 Compare September 7, 2016 21:49
@kmala kmala added the LGTM2 label Sep 7, 2016
@bacongobbler bacongobbler merged commit 2f5c019 into deis:master Sep 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deis tls:info errors if TLS is unset

5 participants