Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

ref(Dockerfile): ditch the pip cache for a slightly smaller image #1051

Merged
helgi merged 1 commit into from
Sep 9, 2016
Merged

ref(Dockerfile): ditch the pip cache for a slightly smaller image #1051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions rootfs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,20 @@ RUN adduser --system \
COPY requirements.txt /app/requirements.txt

RUN buildDeps='gcc git libffi-dev libpq-dev python3-dev'; \
apt-get update && \
apt-get install -y --no-install-recommends \
apt-get update && \
apt-get install -y --no-install-recommends \
$buildDeps \
libpq5 \
python3 \
sudo && \
ln -s /usr/bin/python3 /usr/bin/python && \
curl -sSL https://bootstrap.pypa.io/get-pip.py | python - pip==8.1.2 && \
mkdir -p /configs && chown -R deis:deis /configs && \
pip install --disable-pip-version-check --no-cache-dir -r /app/requirements.txt && \
apt-get purge -y --auto-remove $buildDeps && \
apt-get clean && \
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* /usr/share/man /usr/share/doc
curl -sSL https://bootstrap.pypa.io/get-pip.py | python - pip==8.1.2 && \
mkdir -p /configs && chown -R deis:deis /configs && \
pip install --disable-pip-version-check --no-cache-dir -r /app/requirements.txt && \
Copy link
Copy Markdown
Contributor

@Joshua-Anderson Joshua-Anderson Sep 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't --no-cache-dir already do this?

Copy link
Copy Markdown
Contributor Author

@helgi helgi Sep 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd think but if you drop onto the controller container and dh -h (or similar) that dir, it has data. Can you try it on yours just to confirm?

rm -rf /root/.cache/pip/* && \
apt-get purge -y --auto-remove $buildDeps && \
apt-get clean && \
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* /usr/share/man /usr/share/doc

COPY . /app

Expand Down