Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

chore(requirements) Update to docker-py 1.10.2#1056

Merged
helgi merged 1 commit intodeis:masterfrom
helgi:docker-py
Sep 12, 2016
Merged

chore(requirements) Update to docker-py 1.10.2#1056
helgi merged 1 commit intodeis:masterfrom
helgi:docker-py

Conversation

@helgi
Copy link
Copy Markdown
Contributor

@helgi helgi commented Sep 12, 2016

@helgi helgi added this to the v2.6 milestone Sep 12, 2016
@helgi helgi self-assigned this Sep 12, 2016
@deis-bot
Copy link
Copy Markdown

@mboersma and @bacongobbler are potential reviewers of this pull request based on my analysis of git blame information. Thanks @helgi!

@kmala
Copy link
Copy Markdown
Contributor

kmala commented Sep 12, 2016

i would like to remove the docker login https://github.com/deis/controller/blob/master/rootfs/registry/dockerclient.py#L35 and use custom auth for both pull and push so that we don't save the auth information on the nodes but that can be done as part of separate PR if needed.

@codecov-io
Copy link
Copy Markdown

Current coverage is 87.02% (diff: 100%)

Merging #1056 into master will decrease coverage by 0.02%

@@             master      #1056   diff @@
==========================================
  Files            42         42          
  Lines          3615       3615          
  Methods           0          0          
  Messages          0          0          
  Branches        609        609          
==========================================
- Hits           3147       3146     -1   
- Misses          308        309     +1   
  Partials        160        160          

Powered by Codecov. Last update 29d51d9...14d87cf

@helgi
Copy link
Copy Markdown
Contributor Author

helgi commented Sep 12, 2016

@kmala okay - I guess that means the other functions we use to support that - Hopefully with good enough error handling as well

@helgi helgi merged commit 640d220 into deis:master Sep 12, 2016
@helgi helgi deleted the docker-py branch September 12, 2016 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants