This repository was archived by the owner on May 6, 2020. It is now read-only.
chore(tests): port app logs test from deis/deis#5005#1064
Merged
helgi merged 1 commit intodeis:masterfrom Sep 14, 2016
Merged
Conversation
used has_calls instead of assert_called_with since there are other logs knocking around from AppSettings and others that are not relevant in this test Closes deis#597
|
@krancour, @bacongobbler and @Joshua-Anderson are potential reviewers of this pull request based on my analysis of |
Current coverage is 86.93% (diff: 100%)@@ master #1064 diff @@
==========================================
Files 42 42
Lines 3597 3597
Methods 0 0
Messages 0 0
Branches 609 609
==========================================
- Hits 3128 3127 -1
- Misses 309 310 +1
Partials 160 160
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used has_calls instead of assert_called_with since there are other logs knocking around from AppSettings and others that are not relevant in this test
Closes #597