fix(api): cast DEPLOY_BATCHES and DEPLOY_TIMEOUT to int#1076
fix(api): cast DEPLOY_BATCHES and DEPLOY_TIMEOUT to int#1076bacongobbler merged 1 commit intodeis:masterfrom
Conversation
|
@helgi, @kmala and @Joshua-Anderson are potential reviewers of this pull request based on my analysis of |
|
https://github.com/deis/controller/blob/master/rootfs/scheduler/__init__.py#L374 is where some of that was being cast to int thus far - I like yours better |
bacongobbler
force-pushed
the
cast-envvars-to-int
branch
2 times, most recently
from
ed02614 to
7403843
Compare
bacongobbler
force-pushed
the
cast-envvars-to-int
branch
2 times, most recently
from
c633671 to
8aea0c0
Compare
|
blocked by #1077 |
|
@bacongobbler the |
|
I'm going to fix that up, actually. It's because production settings just fetch the envvar but don't supply a default value for these integers, therefore they become the NoneType. Going to shift it around once #1078 is merged. |
|
Sounds good - I'm sure there are defaults being set through the scheduler / app model that probably could just be shifted all the way up to the settings file |
bacongobbler
force-pushed
the
cast-envvars-to-int
branch
2 times, most recently
from
559efe1 to
e3ffda8
Compare
Otherwise it will be a string in the scheduler code and break it.
bacongobbler
force-pushed
the
cast-envvars-to-int
branch
from
e3ffda8 to
1b7c64c
Compare
Current coverage is 87.14% (diff: 100%)@@ master #1076 diff @@
==========================================
Files 42 42
Lines 3601 3601
Methods 0 0
Messages 0 0
Branches 609 609
==========================================
+ Hits 3137 3138 +1
+ Misses 307 306 -1
Partials 157 157
|
6 participants
Otherwise it will be a string in the scheduler code and break it.
closes deis/builder#429