This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(api): fail when rolling back to v1#762
Merged
bacongobbler merged 3 commits intodeis:masterfrom Jul 12, 2016
Merged
Conversation
|
By analyzing the blame information on this pull request, we identified @mboersma, @Joshua-Anderson and @helgi to be potential reviewers |
bacongobbler
force-pushed
the
fail-rollback-v1
branch
from
29d835e to
36171d2
Compare
bacongobbler
force-pushed
the
fail-rollback-v1
branch
4 times, most recently
from
609fc7b to
ee5b338
Compare
Contributor
|
Unit tests are failing on this one |
Member
Author
|
Yeah I'll have to get around for this one. It'd be nice to have for 2.0 but not a priority |
bacongobbler
force-pushed
the
fail-rollback-v1
branch
from
ee5b338 to
263f216
Compare
bacongobbler
force-pushed
the
fail-rollback-v1
branch
2 times, most recently
from
13d3660 to
f253094
Compare
v1 is an intial release created when `deis create` is called, but does not contain any build information.
bacongobbler
force-pushed
the
fail-rollback-v1
branch
from
f253094 to
9893bb0
Compare
Current coverage is 86.73%@@ master #762 diff @@
==========================================
Files 30 30
Lines 2749 2760 +11
Methods 0 0
Messages 0 0
Branches 454 457 +3
==========================================
+ Hits 2384 2394 +10
- Misses 239 240 +1
Partials 126 126
|
Member
Author
|
the github UI is showing red, yet the travis build went green. Go figure. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
v1 is an intial release created when
deis createis called, butdoes not contain any build information.
Issue(s) that this PR Closes
addresses deis/workflow#275 (comment)
Associated End To End Test PR(s)
N/A
Associated Documentation PR(s)
N/A
Pull Request Hygiene TODOs
Please make sure the below checklist is complete.
🌸 Thank you! 🌸