Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

fix(passwd): raise 400 when password is not a parameter#850

Merged
Joshua-Anderson merged 1 commit intodeis:masterfrom
Joshua-Anderson:passwd-fix
Aug 8, 2016
Merged

fix(passwd): raise 400 when password is not a parameter#850
Joshua-Anderson merged 1 commit intodeis:masterfrom
Joshua-Anderson:passwd-fix

Conversation

@Joshua-Anderson
Copy link
Copy Markdown
Contributor

@Joshua-Anderson Joshua-Anderson commented Jul 1, 2016

Summary of Changes

Previously, passwd didn't check if password or new_password was set resulting in server errors when trying to access them.
I haven't wrote any tests, cause I wanted to make sure this was the right approach.
I was also looking at serializers, but it doesn't seem like you can override the serializers on a per-view basis. I'm also concerned about using a DeisException, because I would rather have a field specific error, like serializers do.

Testing Instructions

Please provide a detailed list for how to test the changes in this PR.

  1. Create a normal user.
  2. Try POST /v2/auth/passwd without new_password or password and make sure 500 errors are returned.

@deis-bot
Copy link
Copy Markdown

deis-bot commented Jul 1, 2016

@bacongobbler, @helgi and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @Joshua-Anderson!

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 2, 2016

Current coverage is 81.93% (diff: 100%)

Merging #850 into master will increase coverage by 0.02%

@@             master       #850   diff @@
==========================================
  Files            28         28          
  Lines          3051       3055     +4   
  Methods           0          0          
  Messages          0          0          
  Branches        510        512     +2   
==========================================
+ Hits           2499       2503     +4   
  Misses          404        404          
  Partials        148        148          

Powered by Codecov. Last update 105c514...7777242

@helgi
Copy link
Copy Markdown
Contributor

helgi commented Aug 2, 2016

Can you rebase? And add some tests

@Joshua-Anderson
Copy link
Copy Markdown
Contributor Author

@helgi Rebased and added some tests.

@Joshua-Anderson Joshua-Anderson added this to the v2.4 milestone Aug 5, 2016
@helgi helgi added the LGTM1 label Aug 5, 2016
@Joshua-Anderson Joshua-Anderson force-pushed the passwd-fix branch 2 times, most recently from 37745fb to 32d45c8 Compare August 5, 2016 21:44
@kmala kmala added the LGTM2 label Aug 5, 2016
@Joshua-Anderson Joshua-Anderson force-pushed the passwd-fix branch 2 times, most recently from 6552733 to 7777242 Compare August 8, 2016 15:27
@Joshua-Anderson Joshua-Anderson merged commit c91f361 into deis:master Aug 8, 2016
@Joshua-Anderson Joshua-Anderson deleted the passwd-fix branch August 8, 2016 16:03
duanhongyi pushed a commit to duanhongyi/workflow that referenced this pull request Dec 4, 2018
Add instructions for DNSmasq
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants