Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

fix(scheduler): only attach healthcheck if app is routable#880

Merged
bacongobbler merged 1 commit intodeis:masterfrom
bacongobbler:879-healthchecks-on-routable
Jul 14, 2016
Merged

fix(scheduler): only attach healthcheck if app is routable#880
bacongobbler merged 1 commit intodeis:masterfrom
bacongobbler:879-healthchecks-on-routable

Conversation

@bacongobbler
Copy link
Copy Markdown
Member

fixes #879

@bacongobbler bacongobbler added this to the v2.2 milestone Jul 14, 2016
@bacongobbler bacongobbler self-assigned this Jul 14, 2016
@bacongobbler bacongobbler force-pushed the 879-healthchecks-on-routable branch from 9b3f642 to 9789860 Compare July 14, 2016 18:03
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 14, 2016

Current coverage is 85.76%

No coverage report found for master at a2d55f8.

Powered by Codecov. Last updated by a2d55f8...9b3f642

@bacongobbler
Copy link
Copy Markdown
Member Author

Scheduler module, now with tests!

@helgi helgi added the LGTM1 label Jul 14, 2016
@bacongobbler bacongobbler force-pushed the 879-healthchecks-on-routable branch from 9789860 to c1eca4e Compare July 14, 2016 18:26
@kmala kmala added the LGTM2 label Jul 14, 2016
@bacongobbler
Copy link
Copy Markdown
Member Author

Gonna merge this only because the e2e suite passed, but for some reason the e2e suite couldn't fetch the junit results.

14:58:01 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

@bacongobbler bacongobbler merged commit 2bb7724 into deis:master Jul 14, 2016
@bacongobbler bacongobbler deleted the 879-healthchecks-on-routable branch July 14, 2016 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workers are deployed with a healthcheck

4 participants