This repository was archived by the owner on May 6, 2020. It is now read-only.
feat(scheduler): add scheduler tests that do not go through normal api tests#965
Merged
feat(scheduler): add scheduler tests that do not go through normal api tests#965
Conversation
Contributor
Author
|
There are more tests to write here, just PRing this for some visual codecov.io response and to get visibility on the work |
Current coverage is 85.42% (diff: 72.72%)@@ master #965 diff @@
==========================================
Files 28 28
Lines 3070 3080 +10
Methods 0 0
Messages 0 0
Branches 516 517 +1
==========================================
+ Hits 2512 2631 +119
+ Misses 407 305 -102
+ Partials 151 144 -7
|
|
|
||
| def _scale_deployment(self, namespace, name, image, entrypoint, command, **kwargs): | ||
| """ | ||
| A conveniance wrapper around Deployment update that does a little bit of introspection |
Member
|
Test code looks good, and I'm ok with falling short of the coverage target, since this goes toward that goal |
…i tests This expands the scheduler test suite and can run outside of the API setup. Brings is simple testing per resource type. Also fixes a few mock and scheduler discrepencies that were discovered in the testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the scheduler test suite and can run outside of the API setup. Brings is simple testing per resource type.
Also fixes a few mock and scheduler discrepencies that were discovered in the testing