This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(scheduler): when user asks for limits beyond their allowance then error out faster#975
Merged
helgi merged 1 commit intodeis:masterfrom Aug 12, 2016
Merged
Conversation
a7bee19 to
5c52275
Compare
Current coverage is 85.57% (diff: 38.46%)@@ master #975 diff @@
==========================================
Files 28 28
Lines 3117 3119 +2
Methods 0 0
Messages 0 0
Branches 531 533 +2
==========================================
+ Hits 2662 2669 +7
+ Misses 309 299 -10
- Partials 146 151 +5
|
5c52275 to
1f42fa7
Compare
… error out faster
This detect errors from the pods event stream
Events:
FirstSeenLastSeenCountFromSubobjectPathTypeReasonMessage
------------------------------------------------------------
4m1m2{default-scheduler }WarningFailedSchedulingpod (gaslit-joyrider-cmd-2657344266-tv41n) failed to fit in any node
fit failure on node (ip-172-20-0-109.us-west-2.compute.internal): Node didn't have enough resource: CPU, requested: 2000000, used: 520, capacity: 2000
1f42fa7 to
63c5932
Compare
Member
$ deis limits:set -c cmd=20000 -a inward-inventor
Applying limits... Error: Unknown Error (400): {"detail":"(app::deploy): There was a problem while deploying v3 of inward-inventor-cmd. Going back to the previous release. Additional information:\npod (inward-inventor-cmd-3948341660-3fasy) failed to fit in any node\nfit failure on node (gke-mboersma-default-pool-f041a048-xxs8): Insufficient CPU\nfit failure on node (gke-mboersma-default-pool-f041a048-crig): Insufficient CPU\nfit failure on node (gke-mboersma-default-pool-f041a048-mlza): Insufficient CPU\n"}It's pretty verbose, but informative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This detect errors from the pods event stream by turning the image error handling code into something slightly more generic so we can expand it over time if need be
I made the "failed deploy, going back to old release" contain more contextual information. This can be good but may also get to be busy... Could change it so we log the additional information but do not return it via the API
Testing Instructions
deis pull deis/example-godeis limits:set -c cmd=2000(this should fail)Look at the message that comes back - For now it will not look good since the CLI or SDK (or go?) are not dealing with newlines