Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

ref(hooks): remove push hook model as the builder stopped using it#985

Merged
helgi merged 1 commit intodeis:masterfrom
helgi:remove_push_hook
Aug 18, 2016
Merged

ref(hooks): remove push hook model as the builder stopped using it#985
helgi merged 1 commit intodeis:masterfrom
helgi:remove_push_hook

Conversation

@helgi
Copy link
Copy Markdown
Contributor

@helgi helgi commented Aug 16, 2016

@helgi helgi added this to the v2.5 milestone Aug 16, 2016
@helgi helgi self-assigned this Aug 16, 2016
@deis-bot
Copy link
Copy Markdown

@bacongobbler, @mboersma and @Joshua-Anderson are potential reviewers of this pull request based on my analysis of git blame information. Thanks @helgi!

@helgi helgi force-pushed the remove_push_hook branch from 9f634ac to 18af79e Compare August 16, 2016 21:25
@Joshua-Anderson
Copy link
Copy Markdown
Contributor

Joshua-Anderson commented Aug 16, 2016

Is it okay to break backwards compatibility with the hooks api? It might make sense just to make /v2/hooks/push always return a 200 and mark it as deprecated.

@helgi
Copy link
Copy Markdown
Contributor Author

helgi commented Aug 16, 2016

The current approach only affects people that do not update the builder but do update the controller - That's only a developer workflow as it stands since we do not support that behaviour outside of dev.

That being said I could keep the route, but people could also just clean install dev :P

@bacongobbler
Copy link
Copy Markdown
Member

LGTM since this does not affect the end user at all. This is explicitly an internal API and is not supported outside of the builder/controller.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 18, 2016

Current coverage is 86.21% (diff: 100%)

Merging #985 into master will decrease coverage by 0.12%

@@             master       #985   diff @@
==========================================
  Files            29         28     -1   
  Lines          3191       3155    -36   
  Methods           0          0          
  Messages          0          0          
  Branches        538        537     -1   
==========================================
- Hits           2755       2720    -35   
+ Misses          289        288     -1   
  Partials        147        147          

Powered by Codecov. Last update 4af252d...7b871b4

@helgi helgi force-pushed the remove_push_hook branch from a29050e to 7b871b4 Compare August 18, 2016 01:42
@helgi helgi merged commit f7a3e02 into deis:master Aug 18, 2016
@helgi helgi deleted the remove_push_hook branch August 18, 2016 02:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants