ref(hooks): remove push hook model as the builder stopped using it#985
ref(hooks): remove push hook model as the builder stopped using it#985helgi merged 1 commit intodeis:masterfrom
Conversation
|
@bacongobbler, @mboersma and @Joshua-Anderson are potential reviewers of this pull request based on my analysis of |
9f634ac to
18af79e
Compare
|
Is it okay to break backwards compatibility with the hooks api? It might make sense just to make |
18af79e to
a29050e
Compare
|
The current approach only affects people that do not update the builder but do update the controller - That's only a developer workflow as it stands since we do not support that behaviour outside of dev. That being said I could keep the route, but people could also just clean install dev :P |
|
LGTM since this does not affect the end user at all. This is explicitly an internal API and is not supported outside of the builder/controller. |
Current coverage is 86.21% (diff: 100%)@@ master #985 diff @@
==========================================
Files 29 28 -1
Lines 3191 3155 -36
Methods 0 0
Messages 0 0
Branches 538 537 -1
==========================================
- Hits 2755 2720 -35
+ Misses 289 288 -1
Partials 147 147
|
a29050e to
7b871b4
Compare
ref deis/builder#407