Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

fix(registry): tell a user they need PORT when using off-cluster native iaas registry#988

Merged
helgi merged 1 commit intodeis:masterfrom
helgi:port_fix
Aug 18, 2016
Merged

fix(registry): tell a user they need PORT when using off-cluster native iaas registry#988
helgi merged 1 commit intodeis:masterfrom
helgi:port_fix

Conversation

@helgi
Copy link
Copy Markdown
Contributor

@helgi helgi commented Aug 17, 2016

registry:set does the same kind of warning but since this is a whole platform setting then we need to warn on deploy as well

Fixes #986

Requires off-cluster native iaas cluster to test

deis create --no-remote
Creating Application... done, created august-sandwich
If you want to add a git remote for this app later, use `deis git:remote -a august-sandwich`

deis pull deis/example-go -a august-sandwich
Creating build... Error: Unknown Error (400): {"detail":"PORT needs to be set in the config when using a private registry"}

deis config:set PORT=80 -a august-sandwich
Creating config... done

=== august-sandwich Config
PORT      80

deis pull deis/example-go -a august-sandwich

@helgi helgi added this to the v2.5 milestone Aug 17, 2016
@helgi helgi self-assigned this Aug 17, 2016
@deis-bot
Copy link
Copy Markdown

@bacongobbler and @kmala are potential reviewers of this pull request based on my analysis of git blame information. Thanks @helgi!

@Joshua-Anderson
Copy link
Copy Markdown
Contributor

Is there any way to add tests to this?

@helgi
Copy link
Copy Markdown
Contributor Author

helgi commented Aug 17, 2016

Actually yes I will do that

@helgi
Copy link
Copy Markdown
Contributor Author

helgi commented Aug 18, 2016

Tests added - I had to amend a few other tests as the way the registry setting override had been done didn't gel with the test suite. Moved it all to use @override decorator to contain it to the test function instead of a global override

…ve iaas registry

registry:set does the same kind of warning but since this is a whole platform setting then we need to warn on deploy as well

Fixes deis#986
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants