This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(registry): tell a user they need PORT when using off-cluster native iaas registry#988
Merged
helgi merged 1 commit intodeis:masterfrom Aug 18, 2016
Merged
fix(registry): tell a user they need PORT when using off-cluster native iaas registry#988helgi merged 1 commit intodeis:masterfrom
helgi merged 1 commit intodeis:masterfrom
Conversation
|
@bacongobbler and @kmala are potential reviewers of this pull request based on my analysis of |
Contributor
|
Is there any way to add tests to this? |
Contributor
Author
|
Actually yes I will do that |
Contributor
Author
|
Tests added - I had to amend a few other tests as the way the registry setting override had been done didn't gel with the test suite. Moved it all to use |
…ve iaas registry registry:set does the same kind of warning but since this is a whole platform setting then we need to warn on deploy as well Fixes deis#986
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry:set does the same kind of warning but since this is a whole platform setting then we need to warn on deploy as well
Fixes #986
Requires off-cluster native iaas cluster to test