Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

ref(apps): move AppSettings scheduler logic to App model for simplicity#993

Merged
helgi merged 1 commit intodeis:masterfrom
helgi:appsettings_adjustments
Aug 19, 2016
Merged

ref(apps): move AppSettings scheduler logic to App model for simplicity#993
helgi merged 1 commit intodeis:masterfrom
helgi:appsettings_adjustments

Conversation

@helgi
Copy link
Copy Markdown
Contributor

@helgi helgi commented Aug 19, 2016

No description provided.

@helgi helgi added this to the v2.5 milestone Aug 19, 2016
@helgi helgi self-assigned this Aug 19, 2016
@deis-bot
Copy link
Copy Markdown

@kmala, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @helgi!

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 19, 2016

Current coverage is 86.19% (diff: 83.78%)

Merging #993 into master will decrease coverage by <.01%

@@             master       #993   diff @@
==========================================
  Files            28         28          
  Lines          3154       3152     -2   
  Methods           0          0          
  Messages          0          0          
  Branches        537        537          
==========================================
- Hits           2719       2717     -2   
  Misses          288        288          
  Partials        147        147          

Powered by Codecov. Last update 4e0c5a3...033de6a

@bacongobbler
Copy link
Copy Markdown
Member

massive cleanup. Nice.

@helgi helgi force-pushed the appsettings_adjustments branch from 5d5218e to 033de6a Compare August 19, 2016 20:12
@helgi helgi merged commit d155e92 into deis:master Aug 19, 2016
@helgi helgi deleted the appsettings_adjustments branch August 19, 2016 20:40
@kmala kmala modified the milestones: v.2.4.2, v2.5 Aug 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants