This repository was archived by the owner on Nov 30, 2021. It is now read-only.
fix(Makefile): specify /bin/bash as Makefile $(SHELL)#1380
Closed
fix(Makefile): specify /bin/bash as Makefile $(SHELL)#1380
Conversation
We have one bash-ism in the main Makefile, and we generally expect to use bash, so we should make it explicit. See: https://www.gnu.org/software/make/manual/make.html#Choosing-the-Shell
Contributor
|
Wondering if the better solution here isn't to remove the bash-ism entirely. I proposed a change to this line to @Xe to test - not sure where we got with that. |
Member
Author
|
I think that would be better too if line 51 is the only actual bash-ism, which I think is the case. I am just trying to tidy the CI output mostly. |
Member
Author
|
Jenkins, test this please. |
Contributor
This should be safe for sh and have the same logic... |
Contributor
|
This change messes up the ANSI color code output: |
Xe
added a commit
that referenced
this pull request
Jul 21, 2014
Mac OSX's make has support for `[[`, Ubuntu's does not. This fix (as suggested and written up by @carmstrong on a comment[1]) removed the bashism in favor of a more compatible syntatic trick. [1]: #1380 (comment)
Member
Author
|
Closing in favor of #1382. |
Xe
added a commit
that referenced
this pull request
Jul 21, 2014
Mac OSX's make has support for `[[`, Ubuntu's does not. This fix (as suggested and written up by @carmstrong on a comment[1]) removed the bashism in favor of a more compatible syntatic trick. [1]: #1380 (comment)
Xe
added a commit
that referenced
this pull request
Jul 21, 2014
Mac OSX's make has support for `[[`, Ubuntu's does not. This fix (as suggested and written up by @carmstrong on a comment[1]) removed the bashism in favor of a more compatible syntatic trick. [1]: #1380 (comment) Amended to fix a "$$" in place of a "$"
carmstrong
added a commit
that referenced
this pull request
Jul 21, 2014
fix(Makefile): remove bashism in the main Makefile
Xe
added a commit
that referenced
this pull request
Jul 22, 2014
Mac OSX's make has support for `[[`, Ubuntu's does not. This fix (as suggested and written up by @carmstrong on a comment[1]) removed the bashism in favor of a more compatible syntatic trick. [1]: #1380 (comment) Amended to fix a "$$" in place of a "$"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have one bash-ism in the main Makefile, and we generally expect
to use /bin/bash, so we should make it explicit. See:
https://www.gnu.org/software/make/manual/make.html#Choosing-the-Shell
Fixes #1341.