Skip to content

feat(generate_changelog.go): add changelog entries#157

Merged
vdice merged 1 commit intodeis:masterfrom
vdice:feat/156-global-changelog-additions
Feb 16, 2017
Merged

feat(generate_changelog.go): add changelog entries#157
vdice merged 1 commit intodeis:masterfrom
vdice:feat/156-global-changelog-additions

Conversation

@vdice
Copy link
Copy Markdown
Member

@vdice vdice commented Feb 2, 2017

For the Workflow repo itself (anticipated changelog) and auxiliary
repos such as workflow-cli and workflow-e2e (assumed to already be released)

The default/happy case test would be:

$ make build
$ # simulate last release
$ export WORKFLOW_RELEASE=v2.11.0 WORKFLOW_PREV_RELEASE=v2.10.0
$ helm repo add workflow https://charts.deis.com/workflow # if haven't done so already
$ helm fetch --untar workflow/workflow --version v2.10.0
$ # verify generated changelog shows workflow(-cli,-e2e) changes:
$ ./deisrel changelog global workflow/requirements.lock map.json

There haven't been any commits in deis/workflow since this last v2.11.0 release, but if there were, they would be seen in the following simulated upcoming release:

$ # simulate upcoming release
$ export WORKFLOW_RELEASE=v2.11.1 WORKFLOW_PREV_RELEASE=v2.11.0
$ helm fetch --untar workflow/workflow --version v2.11.0
$ ./deisrel changelog global workflow/requirements.lock map.json

Ref deis/workflow#722

@vdice vdice added this to the v2.12 milestone Feb 2, 2017
@vdice vdice self-assigned this Feb 2, 2017
@vdice vdice force-pushed the feat/156-global-changelog-additions branch from 7cf1bdc to 4b99c82 Compare February 3, 2017 19:38
vdice pushed a commit to vdice/workflow that referenced this pull request Feb 3, 2017
@vdice vdice force-pushed the feat/156-global-changelog-additions branch from 4b99c82 to f3f9d0d Compare February 3, 2017 21:52
vdice pushed a commit to vdice/workflow that referenced this pull request Feb 3, 2017
@vdice vdice force-pushed the feat/156-global-changelog-additions branch 2 times, most recently from 48ab2a8 to 909b6ba Compare February 6, 2017 16:34
map.json Outdated
"postgres": "database",
"redis": "redis",
"registry": "registry",
"registry-proxy": "registry-proxy",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still use this? I thought we're using upstream k8s' registry-proxy now...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point -- not quite merged yet (deis/workflow#734) but should be by end of this milestone. Looks like just one last change technically not released (deis/registry-proxy@v1.1.1...master) but I assume we're fine with dropping that? If so, I'll remove this line.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@mboersma
Copy link
Copy Markdown
Member

I tested this as described in the "simulate last release" section and see appropriate CHANGELOG entries for workflow-cli and friends.

For the Workflow repo itself (anticipated changelog) and auxilliary
repos such as `workflow-cli` and `workflow-e2e` (assumed to already be released)
@vdice vdice force-pushed the feat/156-global-changelog-additions branch from 909b6ba to 96f0c4b Compare February 14, 2017 18:19
@vdice vdice merged commit ac9b96b into deis:master Feb 16, 2017
@vdice vdice deleted the feat/156-global-changelog-additions branch February 16, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants