feat(registry): Allow FROM to refer to the off-cluster docker registry. #101
Conversation
|
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it. |
|
@kmala, @mboersma and @ultimateboy are potential reviewers of this pull request based on my analysis of |
|
If you wouldn't mind amending your commit such that it follows the commit style guide, that would be awesome! That way it'll get picked up by |
|
Yep, I'll reformat, sorry. If it helps for testing the image is available at quay.io/clearbit/dockerbuilder:canary |
|
Jenkins, add to Whitelist |
|
I was assuming the login() will write the creds to the filesystem but thats not true and i had tested this PR by building/pushing an image and also verifying that i can't push the same image from the host on which the build happened. |
|
Attached the "needs rebase" label to note amending the commit first before merging. |
Authenticate to off-cluster registries before building so that the client is able to pull private images specified in the FROM. Note: This only works if the FROM refers to an image on the same registry.
9643994 to
e8763ba
Compare
Authenticate to off-cluster registries before building so that the client is able to pull private images specified in the FROM.
Fixes #100