-
Notifications
You must be signed in to change notification settings - Fork 27
fix(*): move to python3 #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
tested this image manually with example-dockerfile-python and it ran to completion. LGTM 👍 |
|
Sample output: |
|
Oddly this failed on CI though: |
|
Clearly this needs some more attention to string handling and failure cases, but at least the happy path is happy again. |
5a76326 to
39bd9bd
Compare
rootfs/deploy.py
Outdated
| if stream_chunk: | ||
| stream_chunk = stream_chunk.encode('utf-8').strip() | ||
| print(stream_chunk.replace('\n', '')) | ||
| # Must handle chunks as bytes to avoid UnicdoeEncodeError. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: UnicdoeEncodeError should be UnicodeEncodeError
|
woops, looks like I double-LGTM'd this. Let me revert that lol |
39bd9bd to
0b6d8a9
Compare
A Ubuntu medium CVE patch broke docker-py behavior in an odd way that wasn't easily fixed. Switching dockerbuilder to python3 seems to have avoided the damage.
This fix could use thorough reviewing and testing in addition to CI. Especially WRT the string vs. byte differences introduced by Python 3.