This repository was archived by the owner on May 6, 2020. It is now read-only.
feat(fluentd): Adding sumologic plugin support #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it. |
|
@jchauncey and @krancour are potential reviewers of this pull request based on my analysis of |
mattk42
changed the title
mattk42
changed the title
mattk42
changed the title
mattk42
changed the title
This PR adds support for shipping collected logs from fluentd to sumologic. It is configured with a single SUMOLOGIC_COLLECTOR_URL env var added to the DaemonSet
Member
|
I'll review this shortly. We are in the middle of refactoring logger so want to get taht done before I move to this. I am also redoing how we build the fluentd conf. Thanks for submitting this though =) |
Author
|
Closing this as I submitted #35 which works with the refactor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for shipping collected logs from fluentd to sumologic. It is configured with a single SUMOLOGIC_COLLECTOR_URL env var added to the DaemonSet.
Currently it relies on a customized version of the fluentd sumologic plugin, as the original one has multiple issues. Currently the original one relies on using an HTTP Proxy (there has been a PR open to fix this since April) and it also logs at the debug level which causes an infinite loop for us.