ref(makefile): Update makefile to work with new chart structure#92
ref(makefile): Update makefile to work with new chart structure#92jchauncey merged 1 commit intodeis:masterfrom
Conversation
|
@mboersma is a potential reviewer of this pull request based on my analysis of |
| kube-update: update-manifests | ||
| kubectl delete -f manifests/deis-logger-fluentd-daemon.tmp.yaml | ||
| kubectl create -f manifests/deis-logger-fluentd-daemon.tmp.yaml | ||
| install: |
There was a problem hiding this comment.
looks like install target does same as upgrade target -- if so maybe just have install: upgrade ?
There was a problem hiding this comment.
no install performs a --install with the helm upgrade command. but upgrade does not. one if for installing a fresh chart the other is to update the daemonset
There was a problem hiding this comment.
ah makes sense. just curious -- shouldn't the helm upgrade --install ... command (upgrade target) then work for both cases? (Would install if release name not previously existing and would upgrade if it did exist)
There was a problem hiding this comment.
No --install wont work if the release already exists and just a regular upgrade command wont install a chart if a release does not exist.
4 participants
No description provided.