This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Remove HIPPOFACTS logic and bindle client#121
Merged
bacongobbler merged 4 commits intodeislabs:mainfrom Apr 13, 2022
Merged
Conversation
Contributor
Author
|
TODO:
|
1cfd592 to
2350c96
Compare
Merged
Contributor
Author
|
After some feedback from @michelleN, it might be worth keeping around some of the |
Contributor
Author
|
Hmm... I don't see how we can accomplish retaining the I'm going to opt to remove it. Let's revisit the WAGI/HIPPOFACTS story with spin. |
As of Hippo 0.6, the wagi runtime has been replaced with the Spin runtime. The Spin CLI plans to implement commands like `spin deploy` which will be used to package and distribute a Spin application to Hippo.[1] This change reduces the Hippo CLI to the bare minimum. The new role of the Hippo CLI is to implement all of the endpoints available through the hippo-openapi project. This is to help serve as a reference point for those looking to write their own Hippo clients against the hippo-openapi[2] project (like Spin), and it could also serve as a useful administrator tool looking to inspect and/or understand the Hippo API. [1]: spinframework/spin#304 [2]: https://github.com/fermyon/hippo-openapi Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
2350c96 to
abe3d1e
Compare
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
e781ead to
ed7ef4e
Compare
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
This was referenced Apr 13, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Hippo 0.6, the wagi runtime has been replaced with the Spin
runtime. The Spin CLI plans to implement commands like
spin deploywhich will be used to package and distribute a Spin application to
Hippo.[1]
This change reduces the Hippo CLI to the bare minimum. The new role of
the Hippo CLI is to implement all of the endpoints available through the
hippo-openapi project. This is to help serve as a reference point for
those looking to write their own Hippo clients against the
hippo-openapi[2] project (like Spin), and it could also serve as a
useful administrator tool looking to inspect and/or understand the Hippo
API.
Also changed in this PR:
hippo authcommands have been moved one level lower:hippo auth login->hippo loginhippo auth logout->hippo logouthippo auth register->hippo registerhippo auth whoami->hippo whoami[1]: spinframework/spin#304
[2]: https://github.com/fermyon/hippo-openapi
Signed-off-by: Matthew Fisher matt.fisher@fermyon.com