Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Factoring out into repository interfaces#41

Merged
itowlson merged 4 commits intodeislabs:mainfrom
itowlson:repositories
May 21, 2021
Merged

Factoring out into repository interfaces#41
itowlson merged 4 commits intodeislabs:mainfrom
itowlson:repositories

Conversation

@itowlson
Copy link
Copy Markdown
Contributor

@itowlson itowlson commented May 20, 2021

Fixes #38.

This initial work results three repositories over the same DataContext. I feel like grouping these via a Unit Of Work might make more conceptual sense and will explore that. But putting this up in the meantime for discussion. Switched it to a unit of work.

@itowlson itowlson requested a review from bacongobbler May 20, 2021 03:43
@itowlson itowlson marked this pull request as ready for review May 21, 2021 00:14
Copy link
Copy Markdown
Contributor

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! LGTM

@itowlson itowlson merged commit 896d2e2 into deislabs:main May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: use the Repository pattern for fetching entities

2 participants