Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.

Ignore carriage returns in headers#172

Merged
technosophos merged 1 commit intodeislabs:mainfrom
technosophos:fix/171-carriage-return
Mar 8, 2022
Merged

Ignore carriage returns in headers#172
technosophos merged 1 commit intodeislabs:mainfrom
technosophos:fix/171-carriage-return

Conversation

@technosophos
Copy link
Copy Markdown
Contributor

Change header parsing to completely ignore CRs when parsing headers.

Closes #171

Signed-off-by: Matt Butcher matt.butcher@fermyon.com

Signed-off-by: Matt Butcher <matt.butcher@fermyon.com>
@technosophos technosophos force-pushed the fix/171-carriage-return branch from 5c01dcb to 2501e48 Compare March 8, 2022 21:22
@technosophos
Copy link
Copy Markdown
Contributor Author

The broken tests were because of #173 (SSL cert failure). Rebased to include that PR here.

Copy link
Copy Markdown
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested, LGTM

@technosophos technosophos merged commit a5b3e7b into deislabs:main Mar 8, 2022
@technosophos technosophos deleted the fix/171-carriage-return branch March 8, 2022 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot parse response from Go's net/http/cgi package

2 participants