remove very limited use of log dependency#25
Merged
Merged
Conversation
dekellum
force-pushed
the
drop-log-dep
branch
from
November 9, 2020 22:26
07e7491 to
4566154
Compare
dekellum
changed the title
log dependencylog dependency
dekellum
force-pushed
the
drop-log-dep
branch
from
November 10, 2020 18:16
4566154 to
f26bb9f
Compare
Owner
Author
|
Note on CI behavior: actions/checkout/v2 (at least) does a merge PR to its (master) target and tests on that. Proof is the CI test names shown in this last run of tests: these are as per a subsequent/current master HEAD for which this PR is not rebased on. From the test log, checkout: % git checkout --progress --force refs/remotes/pull/25/merge
Note: switching to 'refs/remotes/pull/25/merge'.
You are in 'detached HEAD' state. [...]
HEAD is now at f3bc437 Merge f26bb9f456b40cd4b186cb2013b8327791548b32 into fedf9a16720547f454d9df72165f1f3779d95815 |
dekellum
force-pushed
the
drop-log-dep
branch
from
November 10, 2020 18:47
f26bb9f to
abb4323
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its seems that the
logcrate dependency is only used as a workaround for unspecificError::Headerand other error branches in a few places. This doesn't seem to be worth the weight as dependencies, particularly those with dubious MSRV update/release policies.